KKcorps commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r883325593
##########
pinot-common/src/test/java/org/apache/pinot/common/data/DateTimeFormatSpecTest.java:
##########
@@ -271,4 +271,58 @@ public Object[][] provideTestConstructFormatData() {
});
return entries.toArray(new Object[entries.size()][]);
}
+
+
+ @Test(dataProvider = "testConstructFormatDataProviderPipe")
Review Comment:
Also add tests if data is getting parsed correctly such as
`testFromFormatToMillis`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
