stym06 commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r883306505
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java:
##########
@@ -47,28 +50,75 @@ public class DateTimeFormatSpec {
public static final int MIN_FORMAT_TOKENS = 3;
public static final int MAX_FORMAT_TOKENS = 4;
+ public static final int FORMAT_TIMEFORMAT_POSITION_PIPE = 0;
+ public static final int FORMAT_PATTERN_POSITION_PIPE = 1;
Review Comment:
I agree it looks vague. But I can't quite get my head around how this can be
better achieved.
Would this look good?
```
public static final int FORMAT_TIMEFORMAT_POSITION_PIPE = 0;
public static final int DATETIME_PATTERN_POSITION = 1;
public static final int DATETIME_TIMEZONE_POSITION = 2;
public static final int EPOCH_UNIT_POSITION = 1;
public static final int EPOCH_SIZE_POSITION = 2;
public static final int MIN_FORMAT_TOKENS_PIPE = 1;
public static final int MAX_FORMAT_TOKENS_PIPE = 3;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
