KKcorps commented on code in PR #8779: URL: https://github.com/apache/pinot/pull/8779#discussion_r883320615
########## pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java: ########## @@ -47,28 +50,75 @@ public class DateTimeFormatSpec { public static final int MIN_FORMAT_TOKENS = 3; public static final int MAX_FORMAT_TOKENS = 4; + public static final int FORMAT_TIMEFORMAT_POSITION_PIPE = 0; + public static final int FORMAT_PATTERN_POSITION_PIPE = 1; Review Comment: Yes, this works for now. Just write a small comment mentionin that DATETIME ones are applicable for SDF patterns and EPOCH ones for well, EPOCH format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org