Jackie-Jiang commented on code in PR #8713:
URL: https://github.com/apache/pinot/pull/8713#discussion_r880963562
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -765,31 +766,41 @@ private void handleSubquery(Expression expression, long
requestId, JsonNode json
* - Case-insensitive cluster
* - Table name in the format of [database_name].[table_name]
*
- * Drop the database part if there is no existing table in the format of
[database_name].[table_name], but only
- * [table_name].
+ * If the PinotConfiguration does not allow dots in table name, will do the
below:
+ * Drop the prefix part for the format of [database_name].[table_name], keep
only [table_name].
+ * If the PinotConfiguration allows dots in table name, we will not do the
split
+ * @param tableName the table name in the query
+ * @param tableCache the table case-sensitive cache
+ * @param routingManager the routing mananger for testing whether a route
exists
+ * @param config the Pinot Configuration
+ * @return
*/
- private String getActualTableName(String tableName) {
+ @VisibleForTesting
+ static String getActualTableName(String tableName, TableCache tableCache,
BrokerRoutingManager routingManager,
Review Comment:
What I meant is that the existing code should already be able to handle the
`[database_name].[table_name]` as the table name (line 773, 801, 812 in the
original code). We don't need to introduce the extra logic of reading
properties from the config.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
