dongxiaoman commented on code in PR #8713:
URL: https://github.com/apache/pinot/pull/8713#discussion_r880720287
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -153,10 +153,13 @@ private static Set<ValidationType>
parseTypesToSkipString(@Nullable String types
* <li>Table name shouldn't contain dot or space in it</li>
* </ul>
*/
- public static void validateTableName(TableConfig tableConfig) {
+ public static void validateTableName(TableConfig tableConfig, boolean
allowDots) {
String tableName = tableConfig.getTableName();
- if (tableName.contains(".") || tableName.contains(" ")) {
- throw new IllegalStateException("Table name: '" + tableName + "'
containing '.' or space is not allowed");
+ if (tableName.contains(".") && !allowDots) {
Review Comment:
Added logic and also unit tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
