dongxiaoman commented on code in PR #8713: URL: https://github.com/apache/pinot/pull/8713#discussion_r880719237
########## pinot-common/src/main/java/org/apache/pinot/common/config/provider/TableCache.java: ########## @@ -76,7 +76,7 @@ public class TableCache implements PinotConfigProvider { private final Set<SchemaChangeListener> _schemaChangeListeners = new HashSet<>(); private final ZkHelixPropertyStore<ZNRecord> _propertyStore; - private final boolean _caseInsensitive; + private final boolean _ignoreCase; Review Comment: @Jackie-Jiang I renamed the `caseInSensitive` everywhere to `ignoreCase` because I already got confused during my coding. Negating in naming will cause more trouble. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org