noon-stripe commented on code in PR #8611:
URL: https://github.com/apache/pinot/pull/8611#discussion_r870770105
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -506,13 +510,26 @@ private PartitionUpsertMetadataManager.RecordInfo
getRecordInfo(GenericRow row,
return new PartitionUpsertMetadataManager.RecordInfo(primaryKey, docId,
(Comparable) upsertComparisonValue);
}
+ /**
+ *
+ * This helper function checks if the value is null, which is only
applicable if the column isn't "*",
+ * which is a side effect of metrics aggregation "COUNT" operation.
+ *
+ * @param column
+ * @param value
+ * @return is the value null if the column is an actual data column (not
"*").
+ */
+ private boolean isColumnValueNull(String column, Object value) {
+ return !column.equals("*") && value == null;
+ }
+
private void updateDictionary(GenericRow row) {
for (Map.Entry<String, IndexContainer> entry :
_indexContainerMap.entrySet()) {
- String column = entry.getKey();
+ String column = _ingestionAggregator.getMetricName(entry.getKey());
Review Comment:
I've fixed this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
