noon-stripe commented on code in PR #8611:
URL: https://github.com/apache/pinot/pull/8611#discussion_r870768539
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java:
##########
@@ -1005,7 +1075,7 @@ private int getOrCreateDocId() {
*/
private IdMap<FixedIntArray>
enableMetricsAggregationIfPossible(RealtimeSegmentConfig config,
Review Comment:
Because _recordIdMap is final, it doesn't like it being assigned within a
method. I moved _ingestionAggregator from being a class member and instead have
sourceColumn and valueAggregator as members of IndexContainer. Not touching the
return type of this, but it all works (see code once I update PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
