siddharthteotia commented on code in PR #8642:
URL: https://github.com/apache/pinot/pull/8642#discussion_r865490430
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignmentStrategy.java:
##########
@@ -68,8 +68,8 @@
* </li>
* </ul>
*/
-public class OfflineSegmentAssignment implements SegmentAssignment {
- private static final Logger LOGGER =
LoggerFactory.getLogger(OfflineSegmentAssignment.class);
+public class OfflineSegmentAssignmentStrategy implements
SegmentAssignmentStrategy {
Review Comment:
This does not seem correct to me
OfflineSegmentAssignment or RealtimeSegmentAssignment is not a strategy imo
Regardless of offline v/s realtime, replica group and balanced are the
concrete implementations of strategies
FYI @jasperjiaguo since you are also going to touch related code later
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignmentStrategy.java:
##########
@@ -68,8 +68,8 @@
* </li>
* </ul>
*/
-public class OfflineSegmentAssignment implements SegmentAssignment {
- private static final Logger LOGGER =
LoggerFactory.getLogger(OfflineSegmentAssignment.class);
+public class OfflineSegmentAssignmentStrategy implements
SegmentAssignmentStrategy {
Review Comment:
This does not seem correct to me
OfflineSegmentAssignment or RealtimeSegmentAssignment is not a strategy imo
Regardless of offline v/s realtime, replica group and balanced are the
concrete implementations of strategies
cc @jasperjiaguo since you are also going to touch related code later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
