Jackie-Jiang commented on code in PR #8514:
URL: https://github.com/apache/pinot/pull/8514#discussion_r856470862
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/JsonUtils.java:
##########
@@ -71,12 +88,53 @@ private JsonUtils() {
public static final ObjectReader DEFAULT_READER = DEFAULT_MAPPER.reader();
public static final ObjectWriter DEFAULT_WRITER = DEFAULT_MAPPER.writer();
public static final ObjectWriter DEFAULT_PRETTY_WRITER =
DEFAULT_MAPPER.writerWithDefaultPrettyPrinter();
+ private static final TypeReference<HashMap<String, Object>>
GENERIC_JSON_TYPE =
+ new TypeReference<HashMap<String, Object>>() { };
public static <T> T stringToObject(String jsonString, Class<T> valueType)
throws IOException {
return DEFAULT_READER.forType(valueType).readValue(jsonString);
}
+ public static <T> JsonPojoWithUnparsableProps<T>
stringToObjectAndUnparseableProps(String jsonString, Class<T> klass)
Review Comment:
Can we use `org.apache.commons.lang3.tuple.Pair`? I think we should already
have the dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
