richardstartin commented on code in PR #8513:
URL: https://github.com/apache/pinot/pull/8513#discussion_r853088744
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/creator/BitSlicedIndexCreatorTest.java:
##########
@@ -192,7 +194,9 @@ private void testLong(Dataset<long[]> dataset)
for (long quantile : dataset.quantiles()) {
ImmutableRoaringBitmap reference = dataset.scan(prev, quantile);
ImmutableRoaringBitmap result = reader.getMatchingDocIds(prev,
quantile);
+ int resultCount = reader.getMatchingDocCount(prev, quantile);
assertEquals(result, reference);
+ assertEquals(resultCount, result == null ? 0 :
result.getCardinality());
Review Comment:
It's nullable and this is just to avoid an IDE warning, I can replace it
with `Objects.requireNonNull` (but this is the same thing inlined).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
