INNOCENT-BOY commented on code in PR #8314: URL: https://github.com/apache/pinot/pull/8314#discussion_r852549610
########## pinot-broker/src/main/java/org/apache/pinot/broker/broker/ZkBasicAuthAccessControlFactory.java: ########## @@ -0,0 +1,122 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.broker.broker; + +import com.google.common.base.Preconditions; +import java.util.Collection; +import java.util.Map; +import java.util.Objects; +import java.util.Optional; +import java.util.stream.Collectors; +import org.apache.helix.ZNRecord; +import org.apache.helix.store.zk.ZkHelixPropertyStore; +import org.apache.pinot.broker.api.AccessControl; +import org.apache.pinot.broker.api.HttpRequesterIdentity; +import org.apache.pinot.broker.api.RequesterIdentity; +import org.apache.pinot.common.config.provider.UserCache; +import org.apache.pinot.common.request.BrokerRequest; +import org.apache.pinot.common.utils.BcryptUtils; +import org.apache.pinot.core.auth.BasicAuthPrincipal; +import org.apache.pinot.core.auth.BasicAuthUtils; +import org.apache.pinot.core.auth.ZkBasicAuthPrincipal; +import org.apache.pinot.spi.env.PinotConfiguration; + + +/** + * Zookeeper Basic Authentication based on Pinot Controller UI. + * The user role has been distinguished by user and admin. Only admin can have access to the + * user console page in Pinot controller UI. And admin can change user info (table permission/ + * number of tables/password etc.) or add/delete user without restarting your Pinot clusters, + * and these changes happen immediately. + * Users Configuration store in Helix Zookeeper and encrypted user password via Bcrypt Encryption Algorithm. + * + */ +public class ZkBasicAuthAccessControlFactory extends AccessControlFactory { + private static final String HEADER_AUTHORIZATION = "authorization"; + + private AccessControl _accessControl; + + public ZkBasicAuthAccessControlFactory() { + // left blank + } + + @Override + public void init(PinotConfiguration configuration, ZkHelixPropertyStore<ZNRecord> propertyStore) { + _accessControl = new BasicAuthAccessControl(new UserCache(propertyStore)); + } + + @Override + public AccessControl create() { + return _accessControl; + } + + /** + * Access Control using header-based basic http authentication + */ + private static class BasicAuthAccessControl implements AccessControl { + private Map<String, ZkBasicAuthPrincipal> _name2principal; + private final UserCache _userCache; + + public BasicAuthAccessControl(UserCache userCache) { + _userCache = userCache; + } + + @Override + public boolean hasAccess(RequesterIdentity requesterIdentity) { + return hasAccess(requesterIdentity, null); + } + + @Override + public boolean hasAccess(RequesterIdentity requesterIdentity, BrokerRequest brokerRequest) { Review Comment: @mayankshriv Each query is read from Cache rather than ZK. And This user cache can be updated via Wacher mechanism. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
