richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r848929522
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/BaseOperator.java:
##########
@@ -35,7 +35,7 @@ public final T nextBlock() {
if (Thread.interrupted()) {
throw new EarlyTerminationException();
}
- try (InvocationScope execution =
Tracing.getTracer().createScope(getClass())) {
+ try (InvocationScope ignored =
Tracing.getTracer().createScope(getClass())) {
Review Comment:
calling this `ignored` is kind of missing the point and will mislead the
reader, it's more than just ceremony but a scope. I think they should be called
scope throughout, except when referenced as recordings (so that they can't be
closed without casting)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
