richardstartin commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848902465
##########
pinot-core/src/main/java/org/apache/pinot/core/common/DataFetcher.java:
##########
@@ -415,10 +421,12 @@ private ForwardIndexReaderContext getReaderContext() {
}
void readDictIds(int[] docIds, int length, int[] dictIdBuffer) {
+ Tracing.activeRecording().setInputDataType(_dataType, _singleValue);
Review Comment:
But `InvocationRecording` isn't in control, the tracer decides what is
enabled and what isn't. The only reason for `isEnabled()` in the first place is
to allow instrumentation to save a few cycles here and there without needing to
rely on everything getting inlined and DCEd.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
