richardstartin commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848861991
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/LuceneFSTIndexReader.java:
##########
@@ -61,19 +65,27 @@ public MutableRoaringBitmap getDocIds(String searchQuery) {
@Override
public ImmutableRoaringBitmap getDictIds(String searchQuery) {
- try {
+ try (InvocationScope span =
Tracing.getTracer().createScope(LuceneFSTIndexReader.class)) {
MutableRoaringBitmap dictIds = new MutableRoaringBitmap();
List<Long> matchingIds = RegexpMatcher.regexMatch(searchQuery, _readFST);
for (Long matchingId : matchingIds) {
dictIds.add(matchingId.intValue());
}
+ record(span, matchingIds.size());
Review Comment:
yes, it's supposed to be recording the size of the set but is recorded as
the number of documents. I will just remove this as it isn't very interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
