richardstartin commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848859925
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -131,6 +131,11 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
QueryContext queryContext = queryRequest.getQueryContext();
LOGGER.debug("Incoming request Id: {}, query: {}", requestId,
queryContext);
+ boolean enableTrace = queryRequest.isEnableTrace();
+ if (enableTrace) {
+ Tracing.getTracer().register(requestId);
Review Comment:
Yes, this is problematic for the built in implementation. I will ensure it
is unregistered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
