saurabhd336 commented on code in PR #8502:
URL: https://github.com/apache/pinot/pull/8502#discussion_r847582952


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/HLRealtimeSegmentDataManager.java:
##########
@@ -285,11 +286,13 @@ public void run() {
           _segmentLogger.info("Indexed {} raw events", 
_realtimeSegment.getNumDocsIndexed());
           File tempSegmentFolder = new File(_resourceTmpDir, "tmp-" + 
System.currentTimeMillis());
 
+          SegmentZKMetadataConfig segmentZKMetadataConfig = new 
SegmentZKMetadataConfig();

Review Comment:
   Passing the SegmentZKMetadataConfig is still needed though.. Should I pass 
null instead?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to