saurabhd336 commented on code in PR #8502:
URL: https://github.com/apache/pinot/pull/8502#discussion_r849083233
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/converter/RealtimeSegmentConverter.java:
##########
@@ -53,11 +55,13 @@ public class RealtimeSegmentConverter {
private final List<String> _varLengthDictionaryColumns;
private final boolean _nullHandlingEnabled;
- public RealtimeSegmentConverter(MutableSegmentImpl realtimeSegment, String
outputPath, Schema schema,
- String tableName, TableConfig tableConfig, String segmentName, String
sortedColumn,
- List<String> invertedIndexColumns, List<String> textIndexColumns,
List<String> fstIndexColumns,
- List<String> noDictionaryColumns, List<String>
varLengthDictionaryColumns, boolean nullHandlingEnabled) {
+ public RealtimeSegmentConverter(MutableSegmentImpl realtimeSegment,
SegmentZKPropsConfig segmentZKMetadataConfig,
+ String outputPath, Schema schema, String tableName, TableConfig
tableConfig, String segmentName,
+ String sortedColumn, List<String> invertedIndexColumns, List<String>
textIndexColumns,
+ List<String> fstIndexColumns, List<String> noDictionaryColumns,
List<String> varLengthDictionaryColumns,
+ boolean nullHandlingEnabled) {
_realtimeSegmentImpl = realtimeSegment;
+ _segmentZKMetadataConfig = segmentZKMetadataConfig;
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
