[GitHub] [pinot] KKcorps commented on a diff in pull request #8502: Add zk metadata to segment's metadata.properties file

[GitBox]

KKcorps commented on code in PR #8502:
URL: https://github.com/apache/pinot/pull/8502#discussion_r846998399


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/V1Constants.java:
##########
@@ -76,6 +76,12 @@ private V1Constants() {
       public static final String SEGMENT_PADDING_CHARACTER = 
"segment.padding.character";
 
       public static final String CUSTOM_SUBSET = "custom";
+
+      /**
+       * ZK properties
+       */
+      public static final String SEGMENT_START_OFFSET = "segment.start.offset";

Review Comment:
   We can use `Segment.Realtime.START_OFFSET` in place of this



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org