richardstartin commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r838833182
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/request/context/FunctionContext.java
##########
@@ -84,7 +84,7 @@ public boolean equals(Object o) {
@Override
public int hashCode() {
- return 31 * 31 * _type.hashCode() + 31 * _functionName.hashCode() +
_arguments.hashCode();
Review comment:
This change is a bit concerning because it seems like the value of the
hashCode must be depended on somehow. If that’s the case, constructing
collisions with polynomial hash codes is very easy to do. Do different function
contexts need distinct hash codes for this to work properly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
