richardstartin commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r838825152
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -174,8 +192,9 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
.withIndexDir(_indexDir)
.withCardinality(columnIndexCreationInfo.getDistinctValueCount())
.withDictionary(dictEnabledColumn)
- .withFieldSpec(fieldSpec)
- .withTotalDocs(segmentIndexCreationInfo.getTotalDocs())
Review comment:
Can we keep these one per line? It’s a lot easier to read in my opinion,
and is very standard with builders.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
