xiangfu0 commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r838815411
##########
File path:
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -170,17 +188,14 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
Preconditions.checkState(dictEnabledColumn ||
!invertedIndexColumns.contains(columnName),
"Cannot create inverted index for raw index column: %s", columnName);
- IndexCreationContext.Common context = IndexCreationContext.builder()
- .withIndexDir(_indexDir)
- .withCardinality(columnIndexCreationInfo.getDistinctValueCount())
- .withDictionary(dictEnabledColumn)
- .withFieldSpec(fieldSpec)
- .withTotalDocs(segmentIndexCreationInfo.getTotalDocs())
+ IndexCreationContext.Common context =
IndexCreationContext.builder().withIndexDir(_indexDir)
Review comment:
true, maybe we can add some rules to not join lines that are already
split?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
