INNOCENT-BOY commented on a change in pull request #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r838637904
##########
File path:
pinot-controller/src/main/java/org/apache/pinot/controller/api/access/AccessControlFactory.java
##########
@@ -30,5 +32,8 @@ default void init(PinotConfiguration pinotConfiguration) {
// left blank
}
+ default void init(ZkHelixPropertyStore<ZNRecord> zkHelixPropertyStore) {
+ }
+
Review comment:
@apucher Thanks for your suggestions. I introduce an
init(PinotConfiguration, ZkHelixPropertyStore) that defaults to invoking the
legacy init(PinotConfiguration) method Rather that using instanceof. Looking
forward your review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
