INNOCENT-BOY commented on a change in pull request #8314:
URL: https://github.com/apache/pinot/pull/8314#discussion_r838634927
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/AccessControlFactory.java
##########
@@ -29,10 +31,13 @@
public static final String ACCESS_CONTROL_CLASS_CONFIG = "class";
public abstract void init(PinotConfiguration confguration);
+ public abstract void init(ZkHelixPropertyStore<ZNRecord> propertyStore);
+
public abstract AccessControl create();
- public static AccessControlFactory loadFactory(PinotConfiguration
configuration) {
+ public static AccessControlFactory loadFactory(PinotConfiguration
configuration,
+ ZkHelixPropertyStore<ZNRecord> propertyStore) {
Review comment:
@apucher Thanks for your suggestions. I have changed the signature of
the static loadFactory to include both configuration and property store.
Also I have reconstructed AccessControlFactory and relevant class about
Controller/Broker/Server. And introduce an init(PinotConfiguration,
ZkHelixPropertyStore) that defaults to invoking the legacy
init(PinotConfiguration) method Rather that using instanceof. Looking forward
your review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
