richardstartin commented on a change in pull request #8304: URL: https://github.com/apache/pinot/pull/8304#discussion_r832103839
########## File path: pinot-core/src/main/java/org/apache/pinot/core/operator/transform/function/TrigonometricTransformFunctions.java ########## @@ -0,0 +1,281 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.operator.transform.function; + +import com.google.common.base.Preconditions; +import java.util.List; +import java.util.Map; +import org.apache.pinot.core.operator.blocks.ProjectionBlock; +import org.apache.pinot.core.operator.transform.TransformResultMetadata; +import org.apache.pinot.segment.spi.datasource.DataSource; + + +public class TrigonometricTransformFunctions { + public static class Atan2TransformFunction extends BaseTransformFunction { + public static final String FUNCTION_NAME = "atan2"; + private double[] _result; + private TransformFunction _leftTransformFunction; + private TransformFunction _rightTransformFunction; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + public void init(List<TransformFunction> arguments, Map<String, DataSource> dataSourceMap) { + // Check that there are more than 1 arguments + if (arguments.size() != 2) { + throw new IllegalArgumentException("Exactly 2 arguments are required for Atan2 transform function"); + } + + _leftTransformFunction = arguments.get(0); + _rightTransformFunction = arguments.get(1); + Preconditions.checkArgument( + _leftTransformFunction.getResultMetadata().isSingleValue() || _rightTransformFunction.getResultMetadata() + .isSingleValue(), "Argument must be single-valued for transform function: %s", getName()); + } + + @Override + public TransformResultMetadata getResultMetadata() { + return DOUBLE_SV_NO_DICTIONARY_METADATA; + } + + @Override + public double[] transformToDoubleValuesSV(ProjectionBlock projectionBlock) { + int length = projectionBlock.getNumDocs(); + + if (_result == null || _result.length < length) { + _result = new double[length]; + } + + double[] leftValues = _leftTransformFunction.transformToDoubleValuesSV(projectionBlock); + double[] rightValues = _rightTransformFunction.transformToDoubleValuesSV(projectionBlock); + for (int i = 0; i < length; i++) { + _result[i] = Math.atan2(leftValues[i], rightValues[i]); + } + + return _result; + } + } + + public static class DegreesTransformFunction extends SingleParamMathTransformFunction { + public static final String FUNCTION_NAME = "degrees"; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + protected void applyMathOperator(double[] values, int length) { + for (int i = 0; i < length; i++) { + _results[i] = Math.toDegrees(values[i]); + } + ; + } + } + + public static class AcosTransformFunction extends SingleParamMathTransformFunction { + public static final String FUNCTION_NAME = "acos"; + + @Override + public String getName() { + return FUNCTION_NAME; + } + + @Override + protected void applyMathOperator(double[] values, int length) { + for (int i = 0; i < length; i++) { + _results[i] = Math.acos(values[i]); + } + ; Review comment: Can we just get rid of these semicolons please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
