xiangfu0 commented on a change in pull request #8343:
URL: https://github.com/apache/pinot/pull/8343#discussion_r830594702



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -559,6 +567,58 @@ private BrokerResponseNative handleSQLRequest(long 
requestId, String query, Json
     return brokerResponse;
   }
 
+  private void handleTimestampIndexOverride(PinotQuery pinotQuery)
+      throws JsonProcessingException {
+    Map<Integer, String> pushdownExpressions = new HashMap<>();
+    for (Expression expression : pinotQuery.getSelectList()) {
+      getPushdownExpression(expression, pushdownExpressions);
+      if (!pushdownExpressions.isEmpty()) {
+        pinotQuery.getQueryOptions()
+            .put("pushdown.timestamp.index.expression", new 
ObjectMapper().writeValueAsString(pushdownExpressions));

Review comment:
       Yes, this is for my testing, trying to set the override expressions as a 
map in the query option, then override the function to generated column names.
   
   This should be simpler than modifying each individual transform function. 
Also, we can leverage a similar mechanism for function indexing later on. 
(Timestamp index can be treated as a special function index.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to