richardstartin commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r830593189
########## File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/TimestampIndexGranularity.java ########## @@ -0,0 +1,68 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.config.table; + +import org.apache.commons.lang3.StringUtils; + + +/** + * TimestampIndexGranularity is the enum of different time granularities from MILLIS to YEAR. + */ +public enum TimestampIndexGranularity { + MILLISECOND, SECOND, MINUTE, HOUR, DAY, WEEK, MONTH, QUARTER, YEAR; + + public static final String TIMESTAMP_COLUMN_WITH_GRANULARITY_PATTERN = "$%s$%s"; + + public static String getColumnNameWithGranularity(String column, TimestampIndexGranularity granularity) { Review comment: How often will this get called? If it’s once or more per query I would just concatenate the strings because it’s a lot more efficient. Also more readable (in my opinion). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
