richardstartin commented on a change in pull request #8343: URL: https://github.com/apache/pinot/pull/8343#discussion_r830592803
########## File path: pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/creator/IndexCreationContext.java ########## @@ -59,6 +61,10 @@ boolean hasDictionary(); + Comparable getMinValue(); Review comment: Please don’t add raw types to this interface, Comparable<?> would be much better, otherwise the user needs to use raw types too -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org