klsince commented on a change in pull request #7961:
URL: https://github.com/apache/pinot/pull/7961#discussion_r779947238
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java
##########
@@ -102,6 +103,10 @@ public void init(TableDataManagerConfig
tableDataManagerConfig, String instanceI
if (!_indexDir.exists()) {
Preconditions.checkState(_indexDir.mkdirs());
}
+ _resourceTmpDir = new File(_indexDir, "tmp");
Review comment:
sgtm. `tmp` is fine.
perhaps leave a comment that this cleanup logic handles tmp resource from
TableDataManager specifically, and tmp resources left by others may be cleaned
as well if they happen to be put at tmp folder under table data dir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
