jadami10 commented on a change in pull request #7961:
URL: https://github.com/apache/pinot/pull/7961#discussion_r781682350
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -465,9 +465,9 @@ private void downloadSegmentFromDeepStore(String
segmentName, IndexLoadingConfig
*/
private void untarAndMoveSegment(String segmentName, IndexLoadingConfig
indexLoadingConfig, File segmentTarFile)
throws IOException {
- // TODO: This could leave temporary directories in _indexDir if JVM shuts
down before the temporary directory is
- // deleted. Consider cleaning up all temporary directories when
starting the server.
- File tempSegmentDir = new File(_indexDir, "tmp-" + segmentName + "." +
System.currentTimeMillis());
+ // This could leave temporary directories in _indexDir if JVM shuts down
before the temp directory is deleted.
Review comment:
What exactly do you have in mind here? I'm not sure what jvm config
would make these code paths keep going and eventually delete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
