xiangfu0 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r767058147
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -50,7 +55,7 @@
@ApiResponse(code = 503, message = "Broker is not healthy")
})
public String getBrokerHealth() {
- ServiceStatus.Status status = ServiceStatus.getServiceStatus();
+ ServiceStatus.Status status = ServiceStatus.getServiceStatus(_instanceId);
Review comment:
yes, so the healthcheck will be only the broker's lifecycle. It's not
linked to PinotServiceManager.
When you send the kill signal:
1. PinotSM will set itself to isShuttingDown=true, so PinotSM healthcheck
will Fail. Meanwhile broker healthcheck is still ok.
2. Then PinotSM will stop Broker, then broker will stop and healthcheck will
fail.
So from users' perspective, there is no glitch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
