Jackie-Jiang commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r766280719
##########
File path:
pinot-tools/src/main/java/org/apache/pinot/tools/admin/command/StartServiceManagerCommand.java
##########
@@ -174,7 +174,7 @@ public boolean execute()
throws Exception {
try {
LOGGER.info("Executing command: " + toString());
- if (!startPinotService("SERVICE_MANAGER", this::startServiceManager)) {
+ if (!startPinotService("SERVICE_MANAGER", () -> startServiceManager())) {
Review comment:
Revert?
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -41,6 +43,10 @@
@Inject
private BrokerMetrics _brokerMetrics;
+ @Inject
Review comment:
(nit) Move this to the front :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
