xiangfu0 commented on a change in pull request #7880:
URL: https://github.com/apache/pinot/pull/7880#discussion_r766404263
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerHealthCheck.java
##########
@@ -50,7 +55,7 @@
@ApiResponse(code = 503, message = "Broker is not healthy")
})
public String getBrokerHealth() {
- ServiceStatus.Status status = ServiceStatus.getServiceStatus();
+ ServiceStatus.Status status = ServiceStatus.getServiceStatus(_instanceId);
Review comment:
The reason is current ServiceStatus is a map from instance_id to health
check callback.
Broker healthcheck should only give the healthcheck of broker, not other
component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
