siddharthteotia commented on a change in pull request #7830: URL: https://github.com/apache/pinot/pull/7830#discussion_r764467965
########## File path: pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/FilteredClauseAggregationExecutor.java ########## @@ -0,0 +1,87 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.core.query.aggregation; + +import java.util.ArrayList; +import java.util.List; +import org.apache.pinot.core.operator.blocks.CombinedTransformBlock; +import org.apache.pinot.core.operator.blocks.TransformBlock; +import org.apache.pinot.core.query.aggregation.function.AggregationFunction; +import org.apache.pinot.core.query.aggregation.function.AggregationFunctionUtils; + + +public class FilteredClauseAggregationExecutor implements AggregationExecutor { + protected final AggregationFunction[] _aggregationFunctions; + protected final AggregationResultHolder[] _aggregationResultHolders; + + public FilteredClauseAggregationExecutor(AggregationFunction[] aggregationFunctions) { + _aggregationFunctions = aggregationFunctions; + int numAggregationFunctions = aggregationFunctions.length; + _aggregationResultHolders = new AggregationResultHolder[numAggregationFunctions]; + for (int i = 0; i < numAggregationFunctions; i++) { + _aggregationResultHolders[i] = aggregationFunctions[i].createAggregationResultHolder(); + } + } + + @Override + public void aggregate(TransformBlock transformBlock) { + if (!(transformBlock instanceof CombinedTransformBlock)) { + throw new IllegalArgumentException("FilteredClauseAggregationExecutor only works" + + "with CombinedTransformBlock"); + } + + CombinedTransformBlock combinedTransformBlock = (CombinedTransformBlock) transformBlock; + List<TransformBlock> transformBlockList = combinedTransformBlock.getTransformBlockList(); + int numAggregations = _aggregationFunctions.length; + int transformListOffset = 0; + + for (int i = 0; i < numAggregations; i++) { + AggregationFunction aggregationFunction = _aggregationFunctions[i]; + + if (aggregationFunction.isFilteredAggregation()) { + TransformBlock innerTransformBlock = transformBlockList.get(transformListOffset++); + + if (innerTransformBlock != null) { + int length = innerTransformBlock.getNumDocs(); + aggregationFunction.aggregate(length, _aggregationResultHolders[i], + AggregationFunctionUtils.getBlockValSetMap(aggregationFunction, innerTransformBlock)); + } + } else { + TransformBlock innerTransformBlock = combinedTransformBlock.getNonFilteredAggBlock(); + + if (innerTransformBlock != null) { Review comment: Not sure when the innerBlock can be null ? If the top call to `aggregate()` for this executor was called by `AggregationOperator`, then there are non-zero records to aggregate (whether filtered or non-filtered). `AggregationOperator` should check for EOF based on whether CombinedTransformBlock is null or not ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
