siddharthteotia commented on a change in pull request #7830: URL: https://github.com/apache/pinot/pull/7830#discussion_r764465294
########## File path: pinot-core/src/main/java/org/apache/pinot/core/plan/FilterPlanNode.java ########## @@ -70,9 +71,16 @@ public FilterPlanNode(IndexSegment indexSegment, QueryContext queryContext) { _numDocs = _indexSegment.getSegmentMetadata().getTotalDocs(); } + public FilterPlanNode(IndexSegment indexSegment, QueryContext queryContext, + FilterContext filterContext) { Review comment: Can we rename `filterContext` to `aggregationFilterContext` or something to indicate that this FilterPlanNode is constructed from AggregationPlanNode for FILTERed aggregation ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org