siddharthteotia commented on a change in pull request #7830:
URL: https://github.com/apache/pinot/pull/7830#discussion_r764446789
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InnerSegmentAggregationSingleValueQueriesTest.java
##########
@@ -49,27 +49,49 @@
" GROUP BY column1, column3, column6, column7, column9, column11,
column12, column17, column18";
@Test
- public void testAggregationOnly() {
- String query = "SELECT" + AGGREGATION + " FROM testTable";
Review comment:
For aggregation tests with FILTER clause, can we please also have some
tests where filter is on a transform function and not just identifier ? Let's
also ensure to have all combinations tested - mix of aggregations with and
without FILTER and with/without outer predicate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
