[GitHub] [pinot] jtao15 commented on a change in pull request #7397: [7264] Add Exception to Broker Response When Not All Segments Are Available (Partial Response)

[GitBox]

jtao15 commented on a change in pull request #7397:
URL: https://github.com/apache/pinot/pull/7397#discussion_r715333009



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/SingleConnectionBrokerRequestHandler.java
##########
@@ -126,6 +128,14 @@ protected BrokerResponseNative processBrokerRequest(long 
requestId, BrokerReques
       _brokerMetrics.addMeteredTableValue(rawTableName, 
BrokerMeter.BROKER_RESPONSES_WITH_PROCESSING_EXCEPTIONS, 1);
     }
     if (numServersQueried > numServersResponded) {
+      //get list of servers that did not respond

Review comment:
       (nit)
   ```suggestion
         // Get list of servers that did not respond
   ```

##########
File path: 
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java
##########
@@ -164,13 +166,9 @@ public DataTable processQuery(ServerQueryRequest 
queryRequest, ExecutorService e
     // 4. Broker watches ExternalView change and updates the routing table to 
stop querying the segment
     //
     // After step 2 but before step 4, segment will be missing on server side
-    // TODO: Change broker to watch both IdealState and ExternalView to not 
query the removed segments

Review comment:
       Good catch!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org