[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7397: [7264] Add Exception to Broker Response When Not All Segments Are Available (Partial Response)

[GitBox]

Jackie-Jiang commented on a change in pull request #7397:
URL: https://github.com/apache/pinot/pull/7397#discussion_r709598492



##########
File path: 
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
##########
@@ -487,6 +491,11 @@ private BrokerResponseNative handleSQLRequest(long 
requestId, String query, Json
       _brokerMetrics.addMeteredTableValue(rawTableName, 
BrokerMeter.BROKER_RESPONSES_WITH_NUM_GROUPS_LIMIT_REACHED, 1);
     }
 
+    if (0 != numUnavailableSegments) {

Review comment:
       （code convention) We usually put `numUnavailableSegments != 0`. Suggest 
keeping it consistent for readability. Same for other places




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org