Jackie-Jiang commented on pull request #7397: URL: https://github.com/apache/pinot/pull/7397#issuecomment-920408618
> @Jackie-Jiang I need some help with setting up mocks for writing UTs for these changes on the broker. I went through the code and I see there are no tests for non-literal queries on the broker (where the broker actually does a scatter-gather to/from the servers). Is there a reference where the downstream servers are mocked? That'd of great help. Thanks! There are fake server instance in `ControllerTestUtils`, but not sure if it is possible to reuse it to test the error behavior. Another option is to test it in an integration test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
