klsince commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r704818424
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
##########
@@ -248,19 +249,27 @@ public boolean isPartialUpsertEnabled() {
return _upsertMode == UpsertConfig.Mode.PARTIAL;
}
+ /**
+ * Add or replace an immutable segment created by the REALTIME table.
+ * Skipping segment still in consuming state.
+ */
+ @Override
+ public void addOrReplaceSegment(String segmentName, IndexLoadingConfig
indexLoadingConfig,
+ SegmentMetadata localMetadata, SegmentZKMetadata zkMetadata, boolean
forceDownload)
+ throws Exception {
+ throw new UnsupportedOperationException();
Review comment:
it looks like RealTime table doesn't support RefreshSegmentMsg
[yet](https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/api/upload/ZKOperator.java#L75)
thus no chance to call addOrReplaceSegment() on RT table mgr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
