klsince commented on a change in pull request #7319: URL: https://github.com/apache/pinot/pull/7319#discussion_r704717050
########## File path: pinot-core/src/test/java/org/apache/pinot/core/data/manager/BaseTableDataManagerAcquireSegmentTest.java ########## @@ -240,7 +239,7 @@ public void testReplace() runStorageServer(numQueryThreads, runTimeSec, tableDataManager); // replaces segments while online -// System.out.println("Nops = " + _numQueries + ",nDrops=" + _nDestroys + ",nCreates=" + _allSegments.size()); + // System.out.println("Nops = " + _numQueries + ",nDrops=" + _nDestroys + ",nCreates=" + _allSegments.size()); Review comment: @mcvsubbu thanks for reviewing. about this suggestion, I didn't find a good way to get seed. Instead, it's simpler to set a seed and print it out for record. btw, I see a local random object is used in testReplace() method, but a constant RANDOM object is used in other methods. Is this intended? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org