mcvsubbu commented on a change in pull request #7319:
URL: https://github.com/apache/pinot/pull/7319#discussion_r704738027



##########
File path: 
pinot-core/src/test/java/org/apache/pinot/core/data/manager/BaseTableDataManagerAcquireSegmentTest.java
##########
@@ -240,7 +239,7 @@ public void testReplace()
 
     runStorageServer(numQueryThreads, runTimeSec, tableDataManager);  // 
replaces segments while online
 
-//    System.out.println("Nops = " + _numQueries + ",nDrops=" + _nDestroys + 
",nCreates=" + _allSegments.size());
+    // System.out.println("Nops = " + _numQueries + ",nDrops=" + _nDestroys + 
",nCreates=" + _allSegments.size());

Review comment:
       Probably un-intended. Random is random, no matter if there is one or 
many. I suggest you set the seed to be the current time, and print out that 
value once in the test. Refactor the test to use the same random everywhere




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to