mqliang commented on a change in pull request #6820:
URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r644380205
##########
File path:
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
##########
@@ -1690,6 +1700,23 @@ public void testCompilationInvokedFunction() {
greaterThan = pinotQuery.getFilterExpression().getFunctionCall();
nowTs = greaterThan.getOperands().get(1).getLiteral().getLongValue();
Assert.assertEquals(nowTs, 1577836800000L);
+
+ query = "SELECT ago('PT1H') FROM foo";
+ lowerBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ nowTs = pinotQuery.getSelectList().get(0).getLiteral().getLongValue();
+ upperBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
+ Assert.assertTrue(nowTs >= lowerBound);
+ Assert.assertTrue(nowTs <= upperBound);
+
+ query = "SELECT a FROM foo where time_col > ago('PT1H')";
+ lowerBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
Review comment:
> Can we also ensure that query gets rewritten ? I think the query gets
rewritten to ?
```
SELECT a FROM foo where time_col - ago('PT1H') > 0
```
I don't think the query get rewritten, If I output the complied query, it
looks like:
```
System.out.println(pinotQuery);
PinotQuery(dataSource:DataSource(tableName:foo),
selectList:[Expression(type:IDENTIFIER, identifier:Identifier(name:a))],
filterExpression:Expression(type:FUNCTION,
functionCall:Function(operator:GREATER_THAN,
operands:[Expression(type:IDENTIFIER, identifier:Identifier(name:time_col)),
Expression(type:LITERAL, literal:<Literal longValue:1622672158605>)])))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
