siddharthteotia commented on a change in pull request #6820:
URL: https://github.com/apache/incubator-pinot/pull/6820#discussion_r644394984
##########
File path:
pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java
##########
@@ -1690,6 +1700,23 @@ public void testCompilationInvokedFunction() {
greaterThan = pinotQuery.getFilterExpression().getFunctionCall();
nowTs = greaterThan.getOperands().get(1).getLiteral().getLongValue();
Assert.assertEquals(nowTs, 1577836800000L);
+
+ query = "SELECT ago('PT1H') FROM foo";
+ lowerBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
+ pinotQuery = CalciteSqlParser.compileToPinotQuery(query);
+ nowTs = pinotQuery.getSelectList().get(0).getLiteral().getLongValue();
+ upperBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
+ Assert.assertTrue(nowTs >= lowerBound);
+ Assert.assertTrue(nowTs <= upperBound);
+
+ query = "SELECT a FROM foo where time_col > ago('PT1H')";
+ lowerBound = System.currentTimeMillis() - ONE_HOUR_IN_MS;
Review comment:
Got it. Due to compile time value substitution, there is no need to
rewrite.
##########
File path:
pinot-core/src/test/java/org/apache/pinot/queries/InnerSegmentSelectionSingleValueQueriesTest.java
##########
@@ -80,6 +81,49 @@ public void testSelectLimitZero() {
Assert.assertTrue(resultsBlock.getSelectionResult().isEmpty());
}
+ @Test
+ public void testSelectionOrderByAgoFunction() {
+ String query = "SELECT daysSinceEpoch FROM testTable WHERE "
+ + "dateTimeConvert(daysSinceEpoch, '1:DAYS:EPOCH',
'1:MILLISECONDS:EPOCH', '1:MILLISECONDS') > ago('P1D') "
+ + "ORDER BY daysSinceEpoch LIMIT 10";
+ SelectionOrderByOperator selectionOrderByOperator =
getOperatorForSqlQuery(query);
Review comment:
I think all the code between line 89 to 105 and and 109 to 124 can be
extracted into a private helper function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
