Jackie-Jiang commented on pull request #6820: URL: https://github.com/apache/incubator-pinot/pull/6820#issuecomment-823600656
> I think adding a `period_add(now(), 'PT1H')` function looks much better: > > * It can accept a positive/negative period to get a time before/after a given period. > * The first parameter can not only be `now()`, but also be some other time expression, so much more flexible. > * MySQL has such a function: https://w3resource.com/mysql/date-and-time-functions/mysql-period_add-function.php. MySQL `period_add` is not flexible (first argument is period, second argument is months). IMO, We only need to introduce a `period()` function which can convert period string into millis, then the current arithmetic functions should be good and much more flexible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
