mcvsubbu commented on a change in pull request #6842:
URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r630628874
##########
File path:
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -261,6 +306,22 @@ private void updateInstanceConfigIfNeeded(String host, int
port) {
"Failed to update instance config");
}
+ // Update instance configs with environment specific properties
+ private void updateInstanceConfigWithEnvironmentSpecificConfigs() {
Review comment:
I was not aware of this change. It is not reflected in the design doc
either. Can you make it consistent please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
