[GitHub] [incubator-pinot] desaijay230592 commented on a change in pull request #6842: Core Pinot Environment Provider Implementation Logic to fetch Failure…

[GitBox]

desaijay230592 commented on a change in pull request #6842:
URL: https://github.com/apache/incubator-pinot/pull/6842#discussion_r626956969



##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -321,6 +321,11 @@
     public static final String CONFIG_OF_ENABLE_THREAD_CPU_TIME_MEASUREMENT =
         "pinot.server.instance.enableThreadCpuTimeMeasurement";
     public static final boolean DEFAULT_ENABLE_THREAD_CPU_TIME_MEASUREMENT = 
false;
+
+    // Environment Provider Configs
+    public static final String 
PREFIX_OF_CONFIG_OF_ENVIRONMENT_PROVIDER_FACTORY = 
"pinot.server.environmentProvider.factory";
+    public static final String CONFIG_OF_ENABLE_ENVIRONMENT_PROVIDER_FACTORY = 
"pinot.server.environmentProvider.enabled";
+    public static final String CONFIG_OF_ENVIRONMENT_PROVIDER_TYPE = 
"pinot.server.environmentProvider.type";

Review comment:
       Removed unnecessary variables. Introducing environmentProvider.className 
variable to determine which EnvironmentProvider class to invoke. Please see the 
recent changes.

##########
File path: 
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/HelixServerStarter.java
##########
@@ -103,9 +107,13 @@
 public class HelixServerStarter implements ServiceStartable {
   private static final Logger LOGGER = 
LoggerFactory.getLogger(HelixServerStarter.class);
 
+  private static final String ENVIRONMENT_IDENTIFIER = "environment";
+  private static final String FAILURE_DOMAIN_IDENTIFIER = "failureDomain";

Review comment:
       Done.

##########
File path: 
pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -321,6 +321,11 @@
     public static final String CONFIG_OF_ENABLE_THREAD_CPU_TIME_MEASUREMENT =
         "pinot.server.instance.enableThreadCpuTimeMeasurement";
     public static final boolean DEFAULT_ENABLE_THREAD_CPU_TIME_MEASUREMENT = 
false;
+
+    // Environment Provider Configs
+    public static final String 
PREFIX_OF_CONFIG_OF_ENVIRONMENT_PROVIDER_FACTORY = 
"pinot.server.environmentProvider.factory";
+    public static final String CONFIG_OF_ENABLE_ENVIRONMENT_PROVIDER_FACTORY = 
"pinot.server.environmentProvider.enabled";

Review comment:
       Removed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org