GSharayu commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r618874346
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -150,14 +150,15 @@ function setupCompatTester() {
# Main
#
-if [ $# -ne 1 ] ; then
+if [ $# -ne 2 ] ; then
usage compCheck
fi
COMPAT_TESTER_PATH="pinot-integration-tests/target/pinot-integration-tests-pkg/bin/pinot-compat-test-runner.sh"
# create subdirectories for given commits
workingDir=$1
+testSuiteDir=$2
Review comment:
done!
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/BaseOp.java
##########
@@ -65,6 +66,22 @@ public String getDescription() {
return _description;
}
+ public String getParentDir() {
+ return _parentDir;
+ }
+
+ public void setParentDir(String parentDir) {
+ _parentDir = parentDir;
+ }
+
+ public String getAbsoluteFileName(String fileName) {
+ //change if the file name is relative
+ if(fileName.startsWith("/")) {
+ return fileName;
+ }
+ return _parentDir + "/" + fileName;
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
