GSharayu commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r618821651
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -43,7 +43,7 @@
# get usage of the script
function usage() {
command=$1
- echo "Usage: $command [workingDir]"
+ echo "Usage: $command [workingDir] resourceDir"
Review comment:
done!
##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -173,29 +174,29 @@ fi
# Setup initial cluster with olderCommit and do rolling upgrade
startServices "$oldTargetDir"
-#$COMPAT_TESTER pre-controller-upgrade.yaml 1; if [ $? -ne 0 ]; then exit 1; fi
+#$COMPAT_TESTER $resourceDir pre-controller-upgrade.yaml 1; if [ $? -ne 0 ];
then exit 1; fi
Review comment:
updated!
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/CompatibilityOpsRunner.java
##########
@@ -54,11 +59,11 @@ private boolean runOps() throws Exception {
}
public static void main(String[] args) throws Exception {
- if (args.length != 2) {
+ if (args.length != 3) {
Review comment:
done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
