[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #6828: Add absolute path support for compatibility testing(#6787)

[GitBox]

mcvsubbu commented on a change in pull request #6828:
URL: https://github.com/apache/incubator-pinot/pull/6828#discussion_r618838135



##########
File path: 
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/BaseOp.java
##########
@@ -65,6 +66,22 @@ public String getDescription() {
     return _description;
   }
 
+  public String getParentDir() {
+    return _parentDir;
+  }
+
+  public void setParentDir(String parentDir) {
+    _parentDir = parentDir;
+  }
+
+  public String getAbsoluteFileName(String fileName) {
+    //change if the file name is relative
+    if(fileName.startsWith("/")) {

Review comment:
       file name will always start with "/". Make sure of it in the shell 
script, like I suggested last time.

##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -43,7 +43,7 @@
 # get usage of the script
 function usage() {
   command=$1
-  echo "Usage: $command [workingDir]"
+  echo "Usage: $command [workingDir] testSuiteDir"

Review comment:
       Looks like `workingDir` is not optional, as per line 153 and 160. So, 
remove the square brackets
   ```suggestion
     echo "Usage: $command workingDir testSuiteDir"
   ```

##########
File path: 
pinot-integration-tests/src/test/java/org/apache/pinot/compat/tests/BaseOp.java
##########
@@ -65,6 +66,22 @@ public String getDescription() {
     return _description;
   }
 
+  public String getParentDir() {
+    return _parentDir;
+  }
+
+  public void setParentDir(String parentDir) {
+    _parentDir = parentDir;
+  }
+
+  public String getAbsoluteFileName(String fileName) {
+    //change if the file name is relative
+    if(fileName.startsWith("/")) {
+      return fileName;
+    }
+    return _parentDir + "/" + fileName;

Review comment:
       _paretDir + "config" + "filepath"

##########
File path: compatibility-verifier/compCheck.sh
##########
@@ -150,14 +150,15 @@ function setupCompatTester() {
 # Main
 #
 
-if [ $# -ne 1 ] ; then
+if [ $# -ne 2 ] ; then
   usage compCheck
 fi
 
 
COMPAT_TESTER_PATH="pinot-integration-tests/target/pinot-integration-tests-pkg/bin/pinot-compat-test-runner.sh"
 
 # create subdirectories for given commits
 workingDir=$1
+testSuiteDir=$2

Review comment:
       compute the absolute path here, like I suggested in prev review




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org